Update Danger.js to support IE8 in Quirks mode #2685
Closed
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hasAttribute method requires IE8 Standards mode, while getAttribute is supported also in IE8 compatibility mode. In the limited context of a named attribute expecting to return an integer, checking for null and empty string on getAttribute would be largely equivalent to the result of hasAttribute. This seems to me the only way to extend support to IE8 in compatibility mode since hasAttribute cannot be shimmed. However, I'm not sure this is the only place where changes are needed to support IE8 in compatibility mode.
Contributor
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Contributor
|
See #2169 (comment) |
Collaborator
|
Sorry, we don't support quirks mode and don't have plans to as it's sort of like supporting IE 5.5. (Note that jQuery also doesn't support quirks mode: http://contribute.jquery.org/wont-fix/#quirks-mode) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hasAttribute method requires IE8 Standards mode, while getAttribute is supported also in IE8 compatibility mode. In the limited context of a named attribute expecting to return an integer, checking for null and empty string on getAttribute would be largely equivalent to the result of hasAttribute. This seems to me the only way to extend support to IE8 in compatibility mode since hasAttribute cannot be shimmed. However, I'm not sure this is the only place where changes are needed to support IE8 in compatibility mode.