Skip to content

cleanup[devtools]: remove named hooks & profiler changed hook indices feature flags #26635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Apr 17, 2023

Summary

Removing enableNamedHooksFeature, enableProfilerChangedHookIndices, enableProfilerComponentTree feature flags, they are the same for all configurations.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 17, 2023
@hoxyq hoxyq force-pushed the cleanup/remove-stale-feature-flags branch from af81ee9 to 4719ca9 Compare April 17, 2023 14:36
@hoxyq hoxyq requested a review from mondaychen April 17, 2023 15:01
@hoxyq hoxyq marked this pull request as ready for review April 17, 2023 15:01
@hoxyq hoxyq merged commit b90e8eb into facebook:main Apr 19, 2023
@hoxyq hoxyq deleted the cleanup/remove-stale-feature-flags branch April 19, 2023 09:05
hoxyq added a commit that referenced this pull request Apr 20, 2023
Full list of changes:
* Use .slice() for all substring-ing
([sophiebits](https://github.com/sophiebits) in
[#26677](#26677))
* cleanup[devtools]: remove named hooks & profiler changed hook indices
feature flags ([hoxyq](https://github.com/hoxyq) in
[#26635](#26635))
* chore[devtools/release-scripts]: update messages / fixed npm view com…
([hoxyq](https://github.com/hoxyq) in
[#26660](#26660))
* (patch)[DevTools] bug fix: backend injection logic not working for
undocked devtools window ([mondaychen](https://github.com/mondaychen) in
[#26665](#26665))
* use backend manager to support multiple backends in extension
([mondaychen](https://github.com/mondaychen) in
[#26615](#26615))
kassens pushed a commit that referenced this pull request Apr 21, 2023
… feature flags (#26635)

## Summary

Removing `enableNamedHooksFeature`, `enableProfilerChangedHookIndices`,
`enableProfilerComponentTree` feature flags, they are the same for all
configurations.
kassens pushed a commit that referenced this pull request Apr 21, 2023
Full list of changes:
* Use .slice() for all substring-ing
([sophiebits](https://github.com/sophiebits) in
[#26677](#26677))
* cleanup[devtools]: remove named hooks & profiler changed hook indices
feature flags ([hoxyq](https://github.com/hoxyq) in
[#26635](#26635))
* chore[devtools/release-scripts]: update messages / fixed npm view com…
([hoxyq](https://github.com/hoxyq) in
[#26660](#26660))
* (patch)[DevTools] bug fix: backend injection logic not working for
undocked devtools window ([mondaychen](https://github.com/mondaychen) in
[#26665](#26665))
* use backend manager to support multiple backends in extension
([mondaychen](https://github.com/mondaychen) in
[#26615](#26615))
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
… feature flags (facebook#26635)

## Summary

Removing `enableNamedHooksFeature`, `enableProfilerChangedHookIndices`,
`enableProfilerComponentTree` feature flags, they are the same for all
configurations.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Full list of changes:
* Use .slice() for all substring-ing
([sophiebits](https://github.com/sophiebits) in
[facebook#26677](facebook#26677))
* cleanup[devtools]: remove named hooks & profiler changed hook indices
feature flags ([hoxyq](https://github.com/hoxyq) in
[facebook#26635](facebook#26635))
* chore[devtools/release-scripts]: update messages / fixed npm view com…
([hoxyq](https://github.com/hoxyq) in
[facebook#26660](facebook#26660))
* (patch)[DevTools] bug fix: backend injection logic not working for
undocked devtools window ([mondaychen](https://github.com/mondaychen) in
[facebook#26665](facebook#26665))
* use backend manager to support multiple backends in extension
([mondaychen](https://github.com/mondaychen) in
[facebook#26615](facebook#26615))
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
… feature flags (#26635)

## Summary

Removing `enableNamedHooksFeature`, `enableProfilerChangedHookIndices`,
`enableProfilerComponentTree` feature flags, they are the same for all
configurations.

DiffTrain build for commit b90e8eb.
Akshato07 pushed a commit to Akshato07/-Luffy that referenced this pull request Feb 20, 2025
Full list of changes:
* Use .slice() for all substring-ing
([sophiebits](https://github.com/sophiebits) in
[#26677](facebook/react#26677))
* cleanup[devtools]: remove named hooks & profiler changed hook indices
feature flags ([hoxyq](https://github.com/hoxyq) in
[#26635](facebook/react#26635))
* chore[devtools/release-scripts]: update messages / fixed npm view com…
([hoxyq](https://github.com/hoxyq) in
[#26660](facebook/react#26660))
* (patch)[DevTools] bug fix: backend injection logic not working for
undocked devtools window ([mondaychen](https://github.com/mondaychen) in
[#26665](facebook/react#26665))
* use backend manager to support multiple backends in extension
([mondaychen](https://github.com/mondaychen) in
[#26615](facebook/react#26615))

DiffTrain build for commit facebook/react@7f8c501.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants