Changed 'hasAttribute' function to 'getAttribute' function in Danger.js #2472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The devs have explicitly rejected IE7 support, see #2169. While this may be one of the few things that prevents it from actually running, I'm sure there are many inconsistencies and presents major obstacles for further "React improvements". If you want this, fork an IE7 branch of React, or if someone has already made such a thing available. (EDIT: https://www.npmjs.org/package/react-ie) cc @zpao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the 'hasAttribute' function to 'getAttribute' in Danger.js. The hasAttribute function was the only thing causing React to not work in IE7 when using the appropriate shims.
I tried to find a shim/sham to accomplish this, but it doesn't seem like it can be accomplished with it.
All tests pass, the lint doesn't, but it doesn't pass in master either.