Stop Mutating Merged Lifecycle Results #2464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I gone done a clowny; this started as #2246. |
Collaborator
(No longer quite accurate.) |
Contributor
Author
|
Ha, yeah... I just rebased. Will update the pull request summary. |
Collaborator
|
It's not ideal because we could just have one new object per class/instance instead of one new per mixin. But I hate mixins so I don't care. |
Summary: Currently, `ReactClass` mutates values returned by `getDefaultProps`, `getInitialState`, and `getChildContext`. This is bad because the objects may, for example, be cached and re-used across instances of a React component. This changes `ReactClass` to instead create a new object. In return for allocating a new object, I've replaced `mapObject` with a `for ... in` so that we are no longer allocating an unused object. Fair trade, IMO. Test Plan: Ran unit tests successfully: ``` npm run jest ``` Conflicts: src/core/ReactCompositeComponent.js Conflicts: src/class/ReactClass.js
yungsters
added a commit
that referenced
this pull request
Nov 18, 2014
Stop Mutating Merged Lifecycle Results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently,
ReactClassmutates values returned bygetDefaultProps,getInitialState, andgetChildContext. This is bad because the objects may, for example, be cached and re-used across instances of a React component.This changes
ReactClassto instead create a new object. In return for allocating a new object, I've replacedmapObjectwith afor ... inso that we are no longer allocating an unused object.Fair trade, IMO.
Reviewers: @zpao @sebmarkbage @spicyj
Test Plan:
Ran unit tests successfully: