[Transition Tracing] Remove console.error in clearTransitionForLanes #24319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
approved these changes
Apr 8, 2022
|
Comparing: 8dcedba...7e607be Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
lunaruan
force-pushed
the
remove_console_error
branch
from
2717f6c to
7e607be
Compare
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 13, 2022
We changed the implementation of root.transitionLanes so that, if there is no transitions for a given lane, we use null instead of an array. This means that this error is no longer valid, so we are removing it
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 14, 2022
Summary: This sync includes the following changes: - **[60e63b960](facebook/react@60e63b960 )**: remove console.error in ReactFiberLane ([#24319](facebook/react#24319)) //<Luna Ruan>// - **[ec52a5698](facebook/react@ec52a5698 )**: Fix: Don't call cWU if already unmounted //<Andrew Clark>// - **[46db4e996](facebook/react@46db4e996 )**: Combine deletion phase into single recursive function //<Andrew Clark>// - **[481dece58](facebook/react@481dece58 )**: Use recursion to traverse during mutation phase //<Andrew Clark>// - **[f9e6aef82](facebook/react@f9e6aef82 )**: Wrap try-catch directly around each user function //<Andrew Clark>// - **[bcc1b3121](facebook/react@bcc1b3121 )**: Move reportUncaughtErrorInDev to captureCommitPhaseError //<Andrew Clark>// - **[c99c5f1df](facebook/react@c99c5f1df )**: Move ad hoc flag checks into main switch statement //<Andrew Clark>// - **[54b5b32d5](facebook/react@54b5b32d5 )**: Move Update flag check into each switch case //<Andrew Clark>// - **[e66e7a0fb](facebook/react@e66e7a0fb )**: Inline commitWork into commitMutationOnFiber //<Andrew Clark>// - **[12d7a9ad7](facebook/react@12d7a9ad7 )**: Combine commitWork into single switch statement //<Andrew Clark>// - **[ea7b2ec28](facebook/react@ea7b2ec28 )**: Remove wrong return pointer warning //<Andrew Clark>// Changelog: [General][Changed] - React Native sync for revisions 8dcedba...60e63b9 jest_e2e[run_all_tests] Reviewed By: kacieb Differential Revision: D35581192 fbshipit-source-id: d8674d2871612d2f27eaf8d75ff05e54ab91271d
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
We changed the implementation of root.transitionLanes so that, if there is no transitions for a given lane, we use null instead of an array. This means that this error is no longer valid, so we are removing it
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
We changed the implementation of root.transitionLanes so that, if there is no transitions for a given lane, we use null instead of an array. This means that this error is no longer valid, so we are removing it
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 19, 2022
We changed the implementation of root.transitionLanes so that, if there is no transitions for a given lane, we use null instead of an array. This means that this error is no longer valid, so we are removing it
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: This sync includes the following changes: - **[60e63b960](facebook/react@60e63b960 )**: remove console.error in ReactFiberLane ([facebook#24319](facebook/react#24319)) //<Luna Ruan>// - **[ec52a5698](facebook/react@ec52a5698 )**: Fix: Don't call cWU if already unmounted //<Andrew Clark>// - **[46db4e996](facebook/react@46db4e996 )**: Combine deletion phase into single recursive function //<Andrew Clark>// - **[481dece58](facebook/react@481dece58 )**: Use recursion to traverse during mutation phase //<Andrew Clark>// - **[f9e6aef82](facebook/react@f9e6aef82 )**: Wrap try-catch directly around each user function //<Andrew Clark>// - **[bcc1b3121](facebook/react@bcc1b3121 )**: Move reportUncaughtErrorInDev to captureCommitPhaseError //<Andrew Clark>// - **[c99c5f1df](facebook/react@c99c5f1df )**: Move ad hoc flag checks into main switch statement //<Andrew Clark>// - **[54b5b32d5](facebook/react@54b5b32d5 )**: Move Update flag check into each switch case //<Andrew Clark>// - **[e66e7a0fb](facebook/react@e66e7a0fb )**: Inline commitWork into commitMutationOnFiber //<Andrew Clark>// - **[12d7a9ad7](facebook/react@12d7a9ad7 )**: Combine commitWork into single switch statement //<Andrew Clark>// - **[ea7b2ec28](facebook/react@ea7b2ec28 )**: Remove wrong return pointer warning //<Andrew Clark>// Changelog: [General][Changed] - React Native sync for revisions 8dcedba...60e63b9 jest_e2e[run_all_tests] Reviewed By: kacieb Differential Revision: D35581192 fbshipit-source-id: d8674d2871612d2f27eaf8d75ff05e54ab91271d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the implementation of
root.transitionLanesso that, if there is no transitions for a given lane, we use null instead of an array. This means that this error is no longer valid, so we are removing it