Skip to content

Conversation

@jimjea
Copy link
Contributor

@jimjea jimjea commented Oct 15, 2014

Hello,

I was just reading through your post and noticed a minor change. The sentence originally read, "It's scaled very well for us...". I thought it was a little unclear since it's can mean "it has" or "it is", which can make this sentence take on a whole different meaning.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@zpao
Copy link
Member

zpao commented Oct 15, 2014

This seems like a good change. However we actually have this content duplicated into a more permanent place in our docs - https://github.com/facebook/react/edit/master/docs/docs/thinking-in-react.md. Since this change is small, lets update both places.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@zpao zpao mentioned this pull request Oct 15, 2014
Hello,

I was just reading through your post and noticed a minor change. The sentence originally read, "It's scaled very well for us...". I thought it was a little unclear since it's can mean "it has" or "it is", which can make this sentence take on a whole different meaning.
@jimjea
Copy link
Contributor Author

jimjea commented Oct 15, 2014

Squashed both commits into one for the minor doc change.

@zpao zpao changed the title minor change to post Minor grammar change to Thinking in React Oct 16, 2014
@zpao
Copy link
Member

zpao commented Oct 16, 2014

Thanks!

zpao added a commit that referenced this pull request Oct 16, 2014
Minor grammar change to Thinking in React
@zpao zpao merged commit 5263f61 into facebook:master Oct 16, 2014
zpao added a commit that referenced this pull request Oct 16, 2014
Minor grammar change to Thinking in React
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants