Changed "lifecycle" to "life cycle" on line 369 #2213
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
We actually use "lifecycle" consistently throughout the docs. I know spell check says it's wrong and we may want to distinguish our uses ("lifecycle method" vs "this point in the life cycle") but we should do it across the board, not just here. Want to take a look at the other uses and see if that makes sense? If so, comment here before doing it and let's hear the argument. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@ateich Interested in following up here? If not, no worries; I can close this out. |
|
Going to close out. |
4 participants
No description provided.