Skip to content

Conversation

@zpao
Copy link
Member

@zpao zpao commented Sep 16, 2014

❗ DO NOT MERGE ❗, I'll just push all of this directly, and I still need to amend with the starter kit before that happens.

any last minute feeback? These are the last bits of #2137

zpao and others added 2 commits September 16, 2014 10:10
Travis ran into some problems, hopefully this fixes it.
(cherry picked from commit 808730d)

Conflicts:
	vendor/fbtransform/visitors.js
CHANGELOG.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"…as `stripTypes" maybe?

@sophiebits
Copy link
Collaborator

lgtm

TODO: starter kit for cherry-pick to master
@zpao zpao merged commit 732ffad into facebook:0.11-stable Sep 16, 2014
@gurdasnijor
Copy link

I was a little confused about this: Thejsxexecutable now exposes a --strip-type flag which can be used to remove TypeScript-like type annotations

Is this to support the use of TypeScript directly?

@syranide
Copy link
Contributor

@gurdasnijor As I understood it it's for "Flow", its type annotations look like TypeScript.

@guidobouman
Copy link
Contributor

@syranide Not me bro. =]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants