Move onscroll detection #2181
Merged
Move onscroll detection #2181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than checking if document.onscroll exists in EventPluginHub (which is agnostic of the DOM) do it in ReactDOMComponent
This moves it to the appropriate place to accomodate the move of the check.
zpao
force-pushed
the
move-onscroll-detection
branch
from
9e925bc to
def41df
Compare
Contributor
|
Why don't we just attach the |
This was referenced Jul 27, 2021
This was referenced Sep 15, 2021
This was referenced Apr 7, 2022
This was referenced Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2175 with the test moved & updated.