Skip to content

Conversation

@mhintz
Copy link
Contributor

@mhintz mhintz commented Sep 9, 2014

Edit the description of componentDidMount() to make clear that the function is called only once during the lifecycle of the component, after only the initial render() call. The description is now similar to that for componentWillMount(). The existing wording does not make it clear that the function is called only after the initial render. (Granted, it is possible to infer this from descriptions of the component lifecycle found elsewhere in the documentation, but I think explicit is better than implicit in this case).

Edit the description of componentDidMount() to make clear that the function is called only once during the lifecycle of the component, after only the initial render() call. The description is now similar to that for componentWillMount(). The existing wording does not make it clear that the function is called only after the initial render. (Granted, it is possible to infer this from descriptions of the component lifecycle found elsewhere in the documentation, but I think explicit is better than implicit in this case).
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@mhintz
Copy link
Contributor Author

mhintz commented Sep 9, 2014

Aha, good point. I signed the agreement. Cheers!

@zpao
Copy link
Member

zpao commented Sep 9, 2014

👍

zpao added a commit that referenced this pull request Sep 9, 2014
Update ref-03-component-specs.md
@zpao zpao merged commit 53be390 into facebook:master Sep 9, 2014
zpao added a commit that referenced this pull request Sep 24, 2014
Update ref-03-component-specs.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants