Fix DevTools handling of empty Suspense tag for legacy renderer versions #19337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
bvaughn
commented
Jul 13, 2020
|
|
||
| function EmptySuspense() { | ||
| return <Suspense />; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Technically this fixture doesn't help here since React and DevTools are in-sync, but it seemed nice to cover this missing case for the future.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d162092:
|
gaearon
approved these changes
Jul 13, 2020
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Are there more similar places to revisit?
Contributor
Author
|
I don't think so. This regression was introduced in #19108 and I think the only other branch impacted in that PR already handled the null-child case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19320
This test should fail the new CI task (to run latest DevTools against all recent minor OSS releases) but that does not yet exist. I will set that up with a follow up PR.