Change retry priority to "Never" for dehydrated boundaries #17105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
approved these changes
Oct 16, 2019
This changes the "default" retryTime to NoWork which schedules at Normal pri. Dehydrated bouundaries normally hydrate at Never priority except when they retry where we accidentally increased them to Normal because Never was used as the default value. This changes it so NoWork is the default. Dehydrated boundaries however get initialized to Never as the default. Therefore they now hydrate as Never pri unless their priority gets increased by a forced rerender or selective hydration. This revealed that erroring at this Never priority can cause an infinite rerender. So I fixed that too.
sebmarkbage
force-pushed
the
dehydrationretrypri
branch
from
3c4c46c to
6e39f06
Compare
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Oct 16, 2019
Fixes test added in facebook#17105, which was based on an earler commit than the one that removed the `unstable_` prefix from `createRoot`.
acdlite
added a commit
that referenced
this pull request
Oct 16, 2019
Fixes test added in #17105, which was based on an earler commit than the one that removed the `unstable_` prefix from `createRoot`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the "default" retryTime to NoWork which schedules at Normal pri.
Dehydrated bouundaries normally hydrate at Never priority except when they retry where we accidentally increased them to Normal because Never was used as the default value. This changes it so NoWork is the default.
Dehydrated boundaries however get initialized to Never as the default.
Therefore they now hydrate as Never pri unless their priority gets increased by a forced rerender or selective hydration.
This revealed that erroring at this Never priority can cause an infinite rerender. So I fixed that too.