Skip to content

Revert "Hide Portals When they aren't wrapped in a host component when Parent Suspends" #17011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunaruan merged 1 commit into from
Oct 4, 2019
Merged

Revert "Hide Portals When they aren't wrapped in a host component when Parent Suspends" #17011

lunaruan merged 1 commit into from
Oct 4, 2019

Conversation

@lunaruan
Copy link
Contributor

@lunaruan lunaruan commented Oct 4, 2019

Reverts #16992

@lunaruan lunaruan requested a review from sebmarkbage October 4, 2019 00:15
@sizebot
Copy link

sizebot commented Oct 4, 2019

Details of bundled changes.

Comparing: 3a2b5f1...0059d4a

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.0% -0.0% 669.47 KB 669.23 KB 145.54 KB 145.52 KB UMD_DEV
react-art.production.min.js -0.1% -0.1% 104 KB 103.87 KB 31.63 KB 31.61 KB UMD_PROD
react-art.development.js -0.0% -0.0% 600.1 KB 599.86 KB 128.13 KB 128.11 KB NODE_DEV
react-art.production.min.js -0.2% -0.2% 69.01 KB 68.89 KB 20.92 KB 20.89 KB NODE_PROD
ReactART-dev.js -0.0% -0.0% 614.81 KB 614.57 KB 127.96 KB 127.94 KB FB_WWW_DEV
ReactART-prod.js -0.2% -0.1% 231.72 KB 231.33 KB 39.13 KB 39.07 KB FB_WWW_PROD

Generated by 🚫 dangerJS against 0059d4a

@lunaruan lunaruan merged commit 4bc52ef into master Oct 4, 2019
@kassens kassens deleted the revert-16992-hide_portal_container branch November 29, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lunaruan @sizebot @sebmarkbage @facebook-github-bot