Skip to content

[react-interactions] Fix virtual click heuristic #16915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
necolas merged 1 commit into from
Sep 27, 2019
Merged

[react-interactions] Fix virtual click heuristic #16915

necolas merged 1 commit into from
Sep 27, 2019

Conversation

@necolas
Copy link
Contributor

@necolas necolas commented Sep 27, 2019

No description provided.

@necolas necolas requested a review from trueadm September 27, 2019 00:57
@necolas necolas mentioned this pull request Sep 27, 2019
Merged
@sizebot
Copy link

sizebot commented Sep 27, 2019

Details of bundled changes.

Comparing: c8dc7a9...5bfc6aa

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/press.development.js 0.0% -0.0% 9.02 KB 9.02 KB 2.66 KB 2.66 KB UMD_DEV
react-interactions-events/tap.development.js +1.6% +2.9% 17.52 KB 17.8 KB 3.74 KB 3.85 KB UMD_DEV
react-interactions-events/focus.production.min.js 0.0% -0.1% 4.31 KB 4.31 KB 1.46 KB 1.46 KB UMD_PROD
react-interactions-events/press.production.min.js 0.0% -0.1% 2.62 KB 2.62 KB 1.09 KB 1.09 KB UMD_PROD
react-interactions-events/tap.production.min.js 0.0% -0.0% 6.23 KB 6.23 KB 2.35 KB 2.35 KB UMD_PROD
react-interactions-events/context-menu.development.js 0.0% -0.1% 2.68 KB 2.68 KB 1007 B 1006 B UMD_DEV
react-interactions-events/scroll.development.js 0.0% -0.1% 6.3 KB 6.3 KB 1.65 KB 1.65 KB UMD_DEV
ReactEventsKeyboard-dev.js +2.9% +3.8% 5.61 KB 5.77 KB 2.1 KB 2.18 KB FB_WWW_DEV
react-interactions-events/scroll.production.min.js 0.0% -0.1% 2.63 KB 2.63 KB 1.15 KB 1.15 KB UMD_PROD
ReactEventsKeyboard-prod.js -3.7% -1.4% 4.07 KB 3.92 KB 1.41 KB 1.39 KB FB_WWW_PROD
react-interactions-events/context-menu.development.js 0.0% -0.1% 2.49 KB 2.49 KB 961 B 960 B NODE_DEV
react-interactions-events/input.development.js 0.0% -0.1% 4.34 KB 4.34 KB 1.4 KB 1.4 KB NODE_DEV
react-interactions-events/scroll.development.js 0.0% -0.1% 6.12 KB 6.12 KB 1.61 KB 1.61 KB NODE_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 669 B 668 B NODE_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.1% 2.44 KB 2.44 KB 1.09 KB 1.09 KB NODE_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.0% 7.31 KB 7.31 KB 2.77 KB 2.77 KB UMD_PROD
react-interactions-events/hover.production.min.js 0.0% -0.2% 2.94 KB 2.94 KB 1.08 KB 1.07 KB NODE_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.0% 7.13 KB 7.13 KB 2.71 KB 2.71 KB NODE_PROD
react-interactions-accessibility/focus-list.production.min.js 0.0% -0.1% 1.57 KB 1.57 KB 792 B 791 B NODE_PROD
react-interactions-events/tap.development.js +1.6% +2.9% 17.34 KB 17.62 KB 3.69 KB 3.79 KB NODE_DEV
react-interactions-events/focus.production.min.js 0.0% -0.1% 4.14 KB 4.14 KB 1.4 KB 1.4 KB NODE_PROD
react-interactions-events/press.production.min.js 0.0% -0.2% 2.33 KB 2.33 KB 1 KB 1 KB NODE_PROD
react-interactions-events/tap.production.min.js 0.0% -0.0% 6.06 KB 6.06 KB 2.3 KB 2.3 KB NODE_PROD
react-interactions-events/keyboard.development.js +3.2% +3.8% 5.79 KB 5.97 KB 2.15 KB 2.24 KB UMD_DEV
react-interactions-events/swipe.development.js 0.0% -0.1% 6 KB 6 KB 1.63 KB 1.63 KB UMD_DEV
react-interactions-events/drag.production.min.js 0.0% -0.1% 2.25 KB 2.25 KB 1.07 KB 1.07 KB UMD_PROD
react-interactions-events/keyboard.production.min.js -1.8% -1.1% 2.44 KB 2.39 KB 1.22 KB 1.21 KB UMD_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.1% 2.45 KB 2.45 KB 1.11 KB 1.11 KB UMD_PROD
ReactEventsTap-dev.js +1.6% +3.0% 17.26 KB 17.53 KB 3.7 KB 3.81 KB FB_WWW_DEV
react-interactions-events/drag.development.js 0.0% 0.0% 6.98 KB 6.98 KB 2.21 KB 2.21 KB NODE_DEV
react-interactions-events/keyboard.development.js +3.3% +3.9% 5.6 KB 5.79 KB 2.11 KB 2.19 KB NODE_DEV
react-interactions-events/swipe.development.js 0.0% -0.1% 5.82 KB 5.82 KB 1.58 KB 1.58 KB NODE_DEV
react-interactions-accessibility/focus-control.development.js 0.0% -0.1% 3.53 KB 3.53 KB 948 B 947 B NODE_DEV
react-interactions-events/keyboard.production.min.js -1.9% -1.4% 2.26 KB 2.22 KB 1.17 KB 1.15 KB NODE_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.1% 2.27 KB 2.27 KB 1.05 KB 1.05 KB NODE_PROD
react-interactions-accessibility/focus-control.production.min.js 0.0% -0.2% 1.25 KB 1.25 KB 614 B 613 B NODE_PROD

Generated by 🚫 dangerJS against 5bfc6aa

@necolas
Copy link
Contributor Author

necolas commented Sep 27, 2019

Weird that yarn flow dom failed locally with errors like "Cannot resolve module react-interactions/events/keyboard." All good here though

trueadm
trueadm approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for pulling this fix in from the feedback we got the other day :)

@necolas necolas merged commit d1121c0 into facebook:master Sep 27, 2019
@necolas necolas deleted the react-interactions/virtual-click-fix branch December 20, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@trueadm trueadm trueadm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@necolas @sizebot @trueadm @facebook-github-bot