Skip to content

[react-interactions] Add wrapping support to FocusList/FocusTable #16903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trueadm merged 1 commit into from
Sep 26, 2019
Merged

[react-interactions] Add wrapping support to FocusList/FocusTable #16903

trueadm merged 1 commit into from
Sep 26, 2019

Conversation

@trueadm
Copy link
Contributor

@trueadm trueadm commented Sep 26, 2019 •
edited
Loading

This adds support to FocusList and FocusTable so that keyboard arrow focus moving can be wrapped back to the other side as requested internally. This also adds an optional onKeyDown prop for TableCell and ListItem so keyboard events can be intercepted.

@trueadm trueadm requested a review from gaearon September 26, 2019 11:40
@sizebot
Copy link

sizebot commented Sep 26, 2019 •
edited
Loading

Details of bundled changes.

Comparing: 3694a3b...9eddac9

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/focus.development.js 0.0% -0.2% 11.81 KB 11.81 KB 2.57 KB 2.57 KB UMD_DEV
react-interactions-events/press.development.js 0.0% -0.1% 9.02 KB 9.02 KB 2.66 KB 2.65 KB UMD_DEV
react-interactions-events/tap.development.js 0.0% -0.1% 17.52 KB 17.52 KB 3.74 KB 3.74 KB UMD_DEV
react-interactions-events/focus.production.min.js 0.0% -0.2% 4.31 KB 4.31 KB 1.46 KB 1.46 KB UMD_PROD
react-interactions-events/press.production.min.js 0.0% -0.2% 2.62 KB 2.62 KB 1.09 KB 1.09 KB UMD_PROD
react-interactions-events/tap.production.min.js 0.0% -0.1% 6.23 KB 6.23 KB 2.35 KB 2.35 KB UMD_PROD
ReactFocusTable-dev.js +18.4% +9.4% 6.85 KB 8.11 KB 1.59 KB 1.74 KB FB_WWW_DEV
ReactFocusList-dev.js +12.9% +11.6% 3.97 KB 4.49 KB 1.03 KB 1.15 KB FB_WWW_DEV
react-interactions-events/context-menu.development.js 0.0% -0.4% 2.68 KB 2.68 KB 1008 B 1004 B UMD_DEV
react-interactions-events/input.development.js 0.0% -0.3% 4.52 KB 4.52 KB 1.45 KB 1.44 KB UMD_DEV
react-interactions-events/scroll.development.js 0.0% -0.2% 6.3 KB 6.3 KB 1.65 KB 1.65 KB UMD_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.5% 1.39 KB 1.39 KB 730 B 726 B UMD_PROD
react-interactions-events/input.production.min.js 0.0% -0.4% 1.84 KB 1.84 KB 985 B 981 B UMD_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.3% 2.63 KB 2.63 KB 1.15 KB 1.14 KB UMD_PROD
react-interactions-events/context-menu.development.js 0.0% -0.3% 2.49 KB 2.49 KB 961 B 958 B NODE_DEV
react-interactions-events/input.development.js 0.0% -0.2% 4.34 KB 4.34 KB 1.4 KB 1.39 KB NODE_DEV
react-interactions-events/scroll.development.js 0.0% -0.2% 6.12 KB 6.12 KB 1.61 KB 1.61 KB NODE_DEV
react-interactions-accessibility/focus-manager.development.js 0.0% -0.4% 2.75 KB 2.75 KB 1.03 KB 1.03 KB NODE_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.4% 1.2 KB 1.2 KB 669 B 666 B NODE_PROD
react-interactions-events/input.production.min.js 0.0% -0.3% 1.66 KB 1.66 KB 918 B 915 B NODE_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.3% 2.44 KB 2.44 KB 1.09 KB 1.09 KB NODE_PROD
react-interactions-accessibility/focus-manager.production.min.js 0.0% -0.4% 1.26 KB 1.26 KB 709 B 706 B NODE_PROD
react-interactions-events/hover.development.js 0.0% -0.2% 7 KB 7 KB 1.56 KB 1.55 KB UMD_DEV
react-interactions-events/press-legacy.development.js 0.0% -0.0% 24.6 KB 24.6 KB 6.07 KB 6.07 KB UMD_DEV
react-interactions-events/hover.production.min.js 0.0% -0.3% 3.12 KB 3.12 KB 1.13 KB 1.13 KB UMD_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.1% 7.31 KB 7.31 KB 2.77 KB 2.76 KB UMD_PROD
react-interactions-events/hover.development.js 0.0% -0.3% 6.82 KB 6.82 KB 1.51 KB 1.51 KB NODE_DEV
react-interactions-events/press-legacy.development.js 0.0% -0.0% 24.41 KB 24.41 KB 6.02 KB 6.02 KB NODE_DEV
react-interactions-accessibility/focus-table.development.js +18.5% +9.1% 7.02 KB 8.32 KB 1.65 KB 1.79 KB NODE_DEV
react-interactions-accessibility/focus-list.development.js +12.5% +10.6% 4.05 KB 4.55 KB 1.06 KB 1.17 KB NODE_DEV
react-interactions-events/hover.production.min.js 0.0% -0.3% 2.94 KB 2.94 KB 1.08 KB 1.07 KB NODE_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.1% 7.13 KB 7.13 KB 2.71 KB 2.71 KB NODE_PROD
react-interactions-accessibility/focus-table.production.min.js 🔺+9.5% 🔺+6.1% 2.37 KB 2.59 KB 1 KB 1.06 KB NODE_PROD
react-interactions-accessibility/focus-list.production.min.js 🔺+14.4% 🔺+11.0% 1.37 KB 1.57 KB 711 B 789 B NODE_PROD
ReactFocusTable-prod.js 🔺+15.4% 🔺+9.1% 6.36 KB 7.34 KB 1.43 KB 1.56 KB FB_WWW_PROD
ReactFocusList-prod.js 🔺+12.0% 🔺+14.7% 3.53 KB 3.96 KB 906 B 1.01 KB FB_WWW_PROD
react-interactions-events/focus.development.js 0.0% -0.2% 11.63 KB 11.63 KB 2.53 KB 2.52 KB NODE_DEV
react-interactions-events/press.development.js 0.0% -0.1% 8.73 KB 8.73 KB 2.58 KB 2.58 KB NODE_DEV
react-interactions-events/tap.development.js 0.0% -0.1% 17.34 KB 17.34 KB 3.69 KB 3.68 KB NODE_DEV
react-interactions-accessibility/tabbable-scope.development.js 0.0% -0.7% 1.2 KB 1.2 KB 599 B 595 B NODE_DEV
react-interactions-events/focus.production.min.js 0.0% -0.2% 4.14 KB 4.14 KB 1.4 KB 1.4 KB NODE_PROD
react-interactions-events/press.production.min.js 0.0% -0.3% 2.33 KB 2.33 KB 1 KB 1 KB NODE_PROD
react-interactions-events/tap.production.min.js 0.0% -0.1% 6.06 KB 6.06 KB 2.3 KB 2.29 KB NODE_PROD
react-interactions-accessibility/tabbable-scope.production.min.js 0.0% -0.7% 662 B 662 B 439 B 436 B NODE_PROD
react-interactions-events/drag.development.js 0.0% -0.2% 5.23 KB 5.23 KB 1.54 KB 1.54 KB UMD_DEV
react-interactions-events/keyboard.development.js 0.0% -0.0% 5.79 KB 5.79 KB 2.16 KB 2.15 KB UMD_DEV
react-interactions-events/swipe.development.js 0.0% -0.2% 6 KB 6 KB 1.63 KB 1.62 KB UMD_DEV
react-interactions-events/drag.production.min.js 0.0% -0.4% 2.25 KB 2.25 KB 1.07 KB 1.07 KB UMD_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.3% 2.45 KB 2.45 KB 1.11 KB 1.1 KB UMD_PROD
react-interactions-events/drag.development.js 0.0% -0.0% 6.98 KB 6.98 KB 2.21 KB 2.21 KB NODE_DEV
react-interactions-events/keyboard.development.js 0.0% -0.0% 5.6 KB 5.6 KB 2.11 KB 2.11 KB NODE_DEV
react-interactions-events/swipe.development.js 0.0% -0.1% 5.82 KB 5.82 KB 1.58 KB 1.58 KB NODE_DEV
react-interactions-accessibility/focus-control.development.js 0.0% -0.1% 3.53 KB 3.53 KB 947 B 946 B NODE_DEV
react-interactions-events/drag.production.min.js 0.0% -0.1% 2.88 KB 2.88 KB 1.38 KB 1.38 KB NODE_PROD
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.26 KB 2.26 KB 1.17 KB 1.17 KB NODE_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.3% 2.27 KB 2.27 KB 1.05 KB 1.05 KB NODE_PROD
react-interactions-accessibility/focus-control.production.min.js 0.0% -0.3% 1.25 KB 1.25 KB 614 B 612 B NODE_PROD

Generated by 🚫 dangerJS against 9eddac9

gaearon
gaearon approved these changes Sep 26, 2019
View reviewed changes
@trueadm
[react-interactions] Add wrapping support to FocusList/FocusTable
9eddac9 
onKeyDown

[react-interactions] Add wrapping support to FocusList/FocusTable
@trueadm trueadm merged commit b9811ed into facebook:master Sep 26, 2019
@trueadm trueadm deleted the a11y-follow-ups branch September 26, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearon gaearon gaearon approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trueadm @sizebot @gaearon @facebook-github-bot