Warning system refactoring (part 1) #16799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This maintains parity with the other warning-like functions.
gaearon
reviewed
Sep 17, 2019
gaearon
reviewed
Sep 17, 2019
Avoids parsing lowPriorityWarning.js itself as the way it forwards the call to lowPriorityWarningWithoutStack is not analyzable.
gaearon
approved these changes
Sep 24, 2019
Collaborator
|
Lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 of the refactoring proposed in #16753
It's pretty much the minimum for now, to make it easier to merge. The
toLowPriorityWarnDevmatcher usage checks still mention thetoWarnDevname, though. It can be fixed by making the matcher name also an argument to the factory, or the matcher could be forked instead of using a factory.