Skip to content

DevTools: Props editing interface tweaks #16740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bvaughn merged 3 commits into from
Sep 10, 2019
Merged

DevTools: Props editing interface tweaks #16740

bvaughn merged 3 commits into from
Sep 10, 2019

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Sep 10, 2019 •
edited
Loading

  • Fix edge-case value input sizing issue with narrow DevTools UIs.
  • Don't allow adding new values unless an overridePropsFn function has been provided.
  • Don't show the "None" empty label at the same time as the "new prop" input.

new-edit-Kapture 2019-09-10 at 14 11 17

@sizebot
Copy link

sizebot commented Sep 10, 2019 •
edited
Loading

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 4ee7d91

@bvaughn bvaughn changed the title Fix DevTools new prop input size DevTools: Props editing interface tweaks Sep 10, 2019
@bvaughn bvaughn merged commit 2c98af7 into facebook:master Sep 10, 2019
@bvaughn bvaughn deleted the devtools-fix-new-prop-input-size branch September 10, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@threepointone threepointone threepointone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bvaughn @sizebot @threepointone @facebook-github-bot