[react-interactions] Add TabFocusContainer and TabbableScope UI components #16732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
FWIW I still don't like the "tab" nomenclature given that these nodes can be reached by means other than pressing the Tab key on a keyboard. |
Contributor
Author
|
@necolas Maybe it should be better named as |
trueadm
changed the title
Contributor
so this component wouldn't work with e.g. a directional pad on a remote control? |
Contributor
Author
|
@necolas that’s right, it would not work with those with this component. |
necolas
approved these changes
Sep 10, 2019
Contributor
necolas
left a comment
necolas
left a comment
There was a problem hiding this comment.
We might want to revisit that limitation in the future but this lgtm for now
packages/react-dom/src/client/focus/__tests__/TabFocusContainer-test.internal.js
Outdated
Show resolved
Hide resolved
packages/react-dom/src/client/focus/__tests__/TabFocusContainer-test.internal.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two experimental components to be used for internal focus management handling. Furthermore, this PR fixes a bug with scope component refs correctly detaching.
TabFocusContainercontains tabbable keyboard focus to within its children, where tabbing gets wrapped to the beginning.TabbableScopecollects host components that are keyboard tabbable so thatTabFocusContainercan handle the tab navigation through said components.