[react-events] Tap: add maximumDistance prop #16689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: e11bf42...6141877 react-events
|
Contributor
|
@necolas I'm not sure its related to these changes, but long press and press via the Enter key don't seem to work for me in that demo (Chrome 76 on macOS) |
necolas
force-pushed
the
react-events/tap-max-distance
branch
from
91b2413 to
ed2e832
Compare
Contributor
Author
|
LongPress will be a separate responder. And see 9ce8711 for related context |
trueadm
approved these changes
Sep 10, 2019
trueadm
reviewed
Sep 10, 2019
Contributor
trueadm
left a comment
trueadm
left a comment
There was a problem hiding this comment.
What happens if the maximumDistance is set to 0? I assume that wouldn't work here? Should we warn against using < 0?
Contributor
Author
Why is that? |
Contributor
|
@necolas Unless I'm mistaken, |
Contributor
Author
|
Yeah I think if you moved back over the initial point, in that case it would not fire |
A prop for configuring the maximum distance that the active pointer can move before the tap is cancelled.
necolas
force-pushed
the
react-events/tap-max-distance
branch
from
ed2e832 to
6141877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prop for configuring the maximum distance that the active pointer can move before the tap is cancelled.
Demo: https://codesandbox.io/s/latest-responder-build-rz96j30rp