Skip to content

Make SchedulerMinHeap flow strict #16351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acdlite merged 1 commit into from
Aug 10, 2019
Merged

Make SchedulerMinHeap flow strict #16351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/scheduler/src/SchedulerMinHeap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @flow strict
*/

type Heap = Array<Node>;
Expand Down Expand Up @@ -38,7 +38,8 @@ export function pop(heap: Heap): Node | null {
}
}

function siftUp(heap, node, index) {
function siftUp(heap, node, i) {
let index = i;
while (true) {
const parentIndex = Math.floor((index - 1) / 2);
const parent = heap[parentIndex];
Expand All @@ -54,7 +55,8 @@ function siftUp(heap, node, index) {
}
}

function siftDown(heap, node, index) {
function siftDown(heap, node, i) {
let index = i;
const length = heap.length;
while (index < length) {
const leftIndex = (index + 1) * 2 - 1;
Expand Down