fix some missing assertions #16336
Merged
fix some missing assertions #16336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were discovered by @SimenB in facebook#16332. We weren't making actual assertions on some values. This PR makes the assertions, and fixes the tests.
threepointone
force-pushed
the
fix-broken-domcomponent-test
branch
from
b5f674b to
5f2ea55
Compare
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
ahtee
approved these changes
Aug 9, 2019
gaearon
approved these changes
Aug 9, 2019
SimenB
reviewed
Aug 9, 2019
| re += quoteRegexp(value) + '[\\\'"]'; | ||
| } | ||
| return new RegExp(re).test(actual); | ||
| expect(new RegExp(re).test(actual)).toBe(true); |
Contributor
There was a problem hiding this comment.
this could be expect(actual).toMatch(new RegExp(re)) fwiw. If it fails, it'll print actual instead of expected false to be true
Contributor
There was a problem hiding this comment.
Certainly! Will update tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were discovered by @SimenB in #16332. We weren't making actual assertions on some values. This PR makes the assertions, and fixes the tests.