[Fresh] Transfer refs when remounting #16241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
approved these changes
Jul 29, 2019
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
Contributor
|
Nice! |
elicwhite
approved these changes
Jul 29, 2019
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Jul 29, 2019
* Add a failing test for refs and remounting * Transfer ref when remounting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, editing a class component would cause refs to it to get nulled after an edit.
This fixes the ref to be transferred on remount so it doesn't get lost. Added a (previously failing) regression test.
Thanks @TheSavior for the bug report.