Skip to content

Conversation

@AGCB
Copy link
Contributor

@AGCB AGCB commented Dec 3, 2018

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  • NONE ADDED
  1. Ensure the test suite passes (yarn test). Tip: yarn test --watch TestName is helpful in development.
  • NEEDED?
  1. Run yarn test-prod to test in the production environment. It supports the same options as yarn test.
  • NEEDED?
  1. If you need a debugger, run yarn debug-test --watch TestName, open chrome://inspect, and press "Inspect".
  • NEEDED?
  1. Format your code with prettier (yarn prettier).
  • NEEDED?
  1. Make sure your code lints (yarn lint). Tip: yarn linc to only check changed files.
  • NEEDED?
  1. Run the Flow typechecks (yarn flow).
  • NEEDED?
  1. If you haven't already, complete the CLA.
  • DONE

Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sophiebits sophiebits merged commit d987172 into facebook:master Dec 4, 2018
@sophiebits
Copy link
Collaborator

Thanks!

trueadm pushed a commit to trueadm/react that referenced this pull request Dec 14, 2018
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants