🔥 Stop syncing the value attribute on inputs (behind a feature flag)#13526

Merged

gaearon merged 24 commits intofacebook:masterfrom

nhunzaker:nh-no-input-value-attribute

Sep 12, 2018

Commits on Sep 12, 2018

:fire: Stop syncing the value attribute on inputs

nhunzaker
authored and
gaearon
committed
Eliminate some additional checks

nhunzaker
authored and
gaearon
committed
Remove initialValue and initialWrapper from wrapperState flow type

nhunzaker
authored and
gaearon
committed
Update tests with new sync logic, reduce some operations

nhunzaker
authored and
gaearon
committed
Update tests, add some caveats for SSR mismatches

nhunzaker
authored and
gaearon
committed
Revert newline change

nhunzaker
authored and
gaearon
committed
Remove unused type

nhunzaker
authored and
gaearon
committed
Call toString to safely type string values

nhunzaker
authored and
gaearon
committed
Add disableInputAttributeSyncing feature flag

nhunzaker
authored and
gaearon
committed
Revert position of types in toStringValues

nhunzaker
authored and
gaearon
committed
Invert flag on number input blur

nhunzaker
authored and
gaearon
committed
Add clarification why double blur is necessary

nhunzaker
authored and
gaearon
committed
Update ReactFire number cases to be more explicite about blur

nhunzaker
authored and
gaearon
committed
Move comments to reduce diff size

nhunzaker
authored and
gaearon
committed
Add comments to clarify behavior in each branch

nhunzaker
authored and
gaearon
committed
There is no need to assign a different checked behavior in Fire

nhunzaker
authored and
gaearon
committed
Use checked reference

nhunzaker
authored and
gaearon
committed
Format

nhunzaker
authored and
gaearon
committed
Avoid precomputing stringable values

nhunzaker
authored and
gaearon
committed
Revert getToStringValue comment

nhunzaker
authored and
gaearon
committed
Revert placement of undefined in getToStringValue

nhunzaker
authored and
gaearon
committed
Do not eagerly stringify value

nhunzaker
authored and
gaearon
committed
Unify Fire test cases with normal ones
gaearon
committed
Revert toString change. Only assign unsynced values when not nully
nhunzaker
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🔥 Stop syncing the value attribute on inputs (behind a feature flag)#13526

🔥 Stop syncing the value attribute on inputs (behind a feature flag)#13526
gaearon merged 24 commits intofacebook:masterfrom
nhunzaker:nh-no-input-value-attribute

Commits on Sep 12, 2018

:fire: Stop syncing the value attribute on inputs

Eliminate some additional checks

Remove initialValue and initialWrapper from wrapperState flow type

Update tests with new sync logic, reduce some operations

Update tests, add some caveats for SSR mismatches

Revert newline change

Remove unused type

Call toString to safely type string values

Add disableInputAttributeSyncing feature flag

Revert position of types in toStringValues

Invert flag on number input blur

Add clarification why double blur is necessary

Update ReactFire number cases to be more explicite about blur

Move comments to reduce diff size

Add comments to clarify behavior in each branch

There is no need to assign a different checked behavior in Fire

Use checked reference

Format

Avoid precomputing stringable values

Revert getToStringValue comment

Revert placement of undefined in getToStringValue

Do not eagerly stringify value

Unify Fire test cases with normal ones

Revert toString change. Only assign unsynced values when not nully