Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Aug 9, 2018

Fixing typos is sometimes very hard. It's not so easy to visually review them. Recently, I discovered a very useful tool for it, misspell.

This pull request fixes minor typos detected by misspell. I've ignored false positives. If you would like me to work on other files as well, let me know.

before

$ misspell . | grep -v node_modules
AUTHORS:959:7: "Broadley" is a misspelling of "Broadly"
AUTHORS:1015:0: "Vitaliy" is a misspelling of "Vitality"
packages/react-dom/src/events/__tests__/ChangeEventPlugin-test.internal.js:657:53: "reponsible" is a misspelling of "responsible"
packages/react-reconciler/src/ReactFiberCommitWork.js:120:84: "overriden" is a misspelling of "overridden"
packages/react-reconciler/src/ReactFiberUnwindWork.js:289:73: "neccessary" is a misspelling of "necessary"
packages/react-reconciler/src/ReactFiberUnwindWork.js:290:71: "Noticable" is a misspelling of "Noticeable"
packages/react-reconciler/src/__tests__/ReactIncrementalErrorReplay-test.internal.js:17:34: "maintaing" is a misspelling of "maintaining"
packages/react-reconciler/src/ReactFiberScheduler.js:1253:34: "Noticable" is a misspelling of "Noticeable"

after

$ misspell . | grep -v node_modules
AUTHORS:959:7: "Broadley" is a misspelling of "Broadly"
AUTHORS:1015:0: "Vitaliy" is a misspelling of "Vitality"

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (yarn test). Tip: yarn test --watch TestName is helpful in development.
  5. Run yarn test-prod to test in the production environment. It supports the same options as yarn test.
  6. If you need a debugger, run yarn debug-test --watch TestName, open chrome://inspect, and press "Inspect".
  7. Format your code with prettier (yarn prettier).
  8. Make sure your code lints (yarn lint). Tip: yarn linc to only check changed files.
  9. Run the Flow typechecks (yarn flow).
  10. If you haven't already, complete the CLA.

Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html

@gaearon gaearon merged commit e020408 into facebook:master Aug 10, 2018
@gaearon
Copy link
Collaborator

gaearon commented Aug 10, 2018

Sure, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants