Improve formatting of errors when building

[misoguy]

Fix #11454
I don't know the history behind using error.codeFrame in catch()
but it seems that rollup is providing with the formatted lines inside error.frame instead of error.codeFrame
What I could find so far about rollup's error.frame is here
and the related getCodeFrame here

[gaearon]

Can you add a screenshot?

[misoguy]

Sure this is the screenshot

[gaearon]

It would be nice to get some syntax highlighting for this. Babel does it.

[misoguy]

Could you add a screenshot of babel's syntax highlighting? To make sure we are on the same page :)

[misoguy]

I'm guessing it's something like this?

[gaearon]

Yes! And it would be nice to remove undefined from the header (when it's undefined).

[gaearon]

Do you plan to finish this with the syntax highlighting?

[misoguy]

I would like to finish this with the syntax highlighting but there seems to be an issue with rollup's error object.
It seems that the error.frame used in this PR which has the error code frame without syntax highlighting also shows wrong line numbers.
The screenshot above shows that the error line is 13 while on the real file the error is on line 12.
I'm looking into rollup's issue regarding this problem but not sure when I can get a fix for it.

Would it be ok to leave this PR open in the mean time?
or should it be merged or closed for a new PR?

[gaearon]

Sure let's keep it open.

[misoguy]

I have a PR open for the issue I mentioned about rollup's error object. rollup/rollup#1728
Hopefully it will be merged and released so that I can get back on track with the syntax highlighting 😄

[misoguy]

@gaearon rollup has been released with my PR merged.
Therefore I have upgraded rollup dependency and added babel-code-frame to finish up with syntax highlighting properly as below 😄

[gaearon]

Can you please send a separate PR for updating Rollup first? Since it may not be obvious from from commit log and it's a substantial change.

Please also run yarn build to record build sizes before and after the change. (As separate commits.) This would tell us if Rollup update accidentally regresses on bundle sizes.

[misoguy]

@gaearon I have sent a separate PR for updating rollup via #11591. I'll rebase this PR to the updated commit once it is merged.

[misoguy]

Finished up this PR by removing rollup upgrade and merging master branch

[gaearon]

CI fails?

[misoguy]

Didn't run yarn prettier 😞 Fixed it now.

[gaearon]

Thanks! This is great.

[gaearon]

It seems like there's an issue in case the error is a syntax error from Babel. Then error.loc.file is missing, and loc reports the wrong line number anyway.

[gaearon]

I fixed with 0182769.