Fix ReactShallowRenderer not rerendering when calling forceUpdate() #11439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Nov 3, 2017
| if (typeof this._instance.shouldComponentUpdate === 'function') { | ||
| if ( | ||
| typeof this._instance.shouldComponentUpdate === 'function' && | ||
| this._forcedUpdate !== true |
Collaborator
There was a problem hiding this comment.
This can just be !this._forcedUpdate, right?
Contributor
Author
There was a problem hiding this comment.
Yes, _forcedUpdate is always a boolean
This was referenced Nov 9, 2017
Update react in packages/oc-template-react from 16.0.0 to 16.1.0
opencomponents/oc-template-react#48
Closed
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
…acebook#11439) * Fix ReactShallowRenderer not rerendering when calling forceUpdate() * Style nit
This was referenced Feb 2, 2018
This was referenced Mar 1, 2018
This was referenced Mar 21, 2018
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
…#11439) * Fix ReactShallowRenderer not rerendering when calling forceUpdate() * Style nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #11239. Unfortunately the fix implemented for #11236 was incorrect and it didn't solve the underlying issue of not rerendering component properly on
forceUpdate.This PR solves the issue and adds necessary test to make sure it's resolved properly this time.