Skip to content

Include component stack in more places, including SSR #11284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 5 commits into from
Oct 19, 2017
Merged

Include component stack in more places, including SSR #11284

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
afbb492
Include component stack in more places, including SSR
gaearon Oct 19, 2017
efce5dc
Forbid including reconciler code into the server bundle
gaearon Oct 19, 2017
add04ef
Tighten up the Flow annotation
gaearon Oct 19, 2017
123a2e2
Fix lint
gaearon Oct 19, 2017
e1d13d1
Gosh Prettier
gaearon Oct 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/react-dom/src/shared/utils/assertValidProps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,7 @@ if (__DEV__) {

var HTML = '__html';

function assertValidProps(
tag: string,
props: ?Object,
getStack: () => string,
) {
function assertValidProps(tag: string, props: ?Object, getStack: () => string) {
Copy link
Contributor

@bvaughn bvaughn Oct 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 "gosh"

if (!props) {
return;
}
Expand Down