-
Notifications
You must be signed in to change notification settings - Fork 50.2k
Remove apostrophe #10807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove apostrophe #10807
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
docs/docs/addons-perf.md
Outdated
| ``` | ||
|
|
||
| Prints the overall time taken. If no argument's passed, defaults to all the measurements from the last recording. This prints a nicely formatted table in the console, like so: | ||
| Prints the overall time taken. If no arguments passed, defaults to all the measurements from the last recording. This prints a nicely formatted table in the console, like so: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an awkward sentance...maybe "When no arguments are passed, printInclusive defaults ..."?
|
Thanks @montogeek and @jquense! I updated based off your suggestion 👍 |
|
This is fine, thanks! The addon itself is not going to work in React 16 though 😞 |
|
@gaearon really?! 😞 why won't the addon work in React 16? Is it something that would be fixable? |
|
Please check the release notes. The blog post mentions this. https://facebook.github.io/react/blog/2017/09/26/react-v16.0.html |
Remove an incorrect apostrophe from the
printInclusivedocumentation and update the sentence.