Skip to content

Conversation

@skovy
Copy link
Contributor

@skovy skovy commented Sep 25, 2017

Remove an incorrect apostrophe from the printInclusive documentation and update the sentence.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

```

Prints the overall time taken. If no argument's passed, defaults to all the measurements from the last recording. This prints a nicely formatted table in the console, like so:
Prints the overall time taken. If no arguments passed, defaults to all the measurements from the last recording. This prints a nicely formatted table in the console, like so:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an awkward sentance...maybe "When no arguments are passed, printInclusive defaults ..."?

@skovy
Copy link
Contributor Author

skovy commented Sep 27, 2017

Thanks @montogeek and @jquense! I updated based off your suggestion 👍

@gaearon
Copy link
Collaborator

gaearon commented Sep 27, 2017

This is fine, thanks! The addon itself is not going to work in React 16 though 😞

@gaearon gaearon merged commit a58e993 into facebook:master Sep 27, 2017
@skovy
Copy link
Contributor Author

skovy commented Sep 27, 2017

@gaearon really?! 😞 why won't the addon work in React 16? Is it something that would be fixable?

@skovy skovy deleted the patch-1 branch September 27, 2017 22:42
@gaearon
Copy link
Collaborator

gaearon commented Sep 27, 2017

Please check the release notes. The blog post mentions this.

https://facebook.github.io/react/blog/2017/09/26/react-v16.0.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants