Pull in react-art/lib/{Circle,Rectangle,Wedge}.art #10629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from [email protected] built files.
Test Plan: Opened the fixture. React logo shows up with its normal dot, now rendered by a `<Circle />`.
flarnie
approved these changes
Sep 6, 2017
packages/react-art/lib/Wedge.art.js
Outdated
| var React = require('react'); | ||
| var ReactART = require('./ReactART'); | ||
|
|
||
| var PropTypes = React.PropTypes; |
Contributor
There was a problem hiding this comment.
Thanks for updating everything while also moving these into the react repo!
Contributor
|
We might not need #10628 now that you removed the |
Collaborator
Author
|
We do still for VectorWidget.js itself. |
flarnie
pushed a commit
to flarnie/react
that referenced
this pull request
Sep 8, 2017
* Import react-art/lib/{Circle,Rectangle,Wedge}.art
Copied from [email protected] built files.
* Changes to built files to make ART shapes work
Test Plan: Opened the fixture. React logo shows up with its normal dot, now rendered by a `<Circle />`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits. First is just a copy/paste. Depends on #10628.
Test Plan: Opened the fixture. React logo shows up with its normal dot, now rendered by a
<Circle />.