Unexpected string key handling

[rymohr]

I came across this one because I'd extended String.prototype.key with a custom key generator. React ends up treating the function itself as the child key, so it hides any strings that come after it.

http://jsfiddle.net/u2b6dac8/2/

Object key handling is documented and makes sense. Not sure it makes sense to handle string keys this way.

http://facebook.github.io/react/docs/multiple-components.html

[sophiebits]

@sebmarkbage what do you want to do here?

react/src/utils/traverseAllChildren.js

Line 112 in bb97482

nameSoFar === '' ? SEPARATOR + getComponentKey(children, 0) : nameSoFar,

[rymohr]

I think the issue is actually here yeah?

react/src/utils/traverseAllChildren.js

Line 48 in bb97482

if (component && component.key != null) {

if (component && component.key != null) {

Should probably be changed to

if (component && component.key != null && typeof component !== "string") {

[sebmarkbage]

Nice catch. I think that we might actually have more of these flaws. We should be more careful as this prevents browsers to add .key to the string prototype.

@spicyj that if branch can be separated and we just use the implicit key for string/number.