Remove version from "line to delete" since we no longer use versions. #9955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @christopherdro and @mkonicek to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
Contributor
|
Do you have some more context for "everything pushes for "com.facebook.react:react-native:+""? |
Contributor
|
I think he is referring to how third party modules are handling react native as a dependency. Overall this change looks fine to me |
Contributor
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
Import Started
Contributor
|
Thanks for importing. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems everything pushes for "com.facebook.react:react-native:+" these days, so just updating the docs to match.