Skip to content

Conversation

@grabbou
Copy link
Contributor

@grabbou grabbou commented Aug 3, 2016

The issue here is that sometimes this.options() is not [options] but contains different stuff, esp. if your command accepts arguments.

This commit reverts its original behaviour and passes custom examples property that we use instead.

Tested, can be shipped right away.

CC: @Kureev @rozele

@ghost
Copy link

ghost commented Aug 3, 2016

By analyzing the blame information on this pull request, we identified @janicduplessis and @rozele to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 3, 2016
@Kureev
Copy link
Contributor

Kureev commented Aug 3, 2016

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Aug 3, 2016
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 3, 2016

Thanks for importing. :trollface:

@ghost ghost added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 3, 2016
@rozele
Copy link
Contributor

rozele commented Aug 3, 2016

👍

@ghost ghost removed the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2016
@ghost
Copy link

ghost commented Aug 4, 2016

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@ghost ghost added Import Failed and removed GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. labels Aug 4, 2016
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2016
@grabbou
Copy link
Contributor Author

grabbou commented Aug 4, 2016

CC: @bestander

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2016
@javache
Copy link
Member

javache commented Aug 4, 2016

Not sure why this wasn't closed. It landed here: 504b516

@javache javache closed this Aug 4, 2016
@javache javache deleted the feat/fix-options-rnpm branch August 4, 2016 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants