Fix scoped modules #9118
Closed
Fix scoped modules #9118
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @grabbou to be a potential reviewer. |
ghost
added
GH Review: review-needed
CLA Signed
Contributor
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
ghost
added
the
CLA Signed
bartolkaruza
pushed a commit
to immidi/react-native
that referenced
this pull request
Aug 3, 2016
Summary: see facebook#8623 **Background:** Back in a days, one buggy patch sneaked into rnpm master. It was intended to fix `react-native-fbsdk` installation for version 0.1.0 (not required in version 0.3.0). Nowadays, we see that this patch break scoped modules `like/this`, so this PR fixes it (basically, reverting the patch). **Test plan (required)** - [x] Try to link unscoped react-native package - [x] Try to link scoped react-native package **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests). Closes facebook#9118 Differential Revision: D3648488 fbshipit-source-id: 1891086ac79a89c888631592c966a8b33fd9c9fd
grabbou
pushed a commit
that referenced
this pull request
Aug 5, 2016
Summary: see #8623 **Background:** Back in a days, one buggy patch sneaked into rnpm master. It was intended to fix `react-native-fbsdk` installation for version 0.1.0 (not required in version 0.3.0). Nowadays, we see that this patch break scoped modules `like/this`, so this PR fixes it (basically, reverting the patch). **Test plan (required)** - [x] Try to link unscoped react-native package - [x] Try to link scoped react-native package **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests). Closes #9118 Differential Revision: D3648488 fbshipit-source-id: 1891086ac79a89c888631592c966a8b33fd9c9fd
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: see facebook#8623 **Background:** Back in a days, one buggy patch sneaked into rnpm master. It was intended to fix `react-native-fbsdk` installation for version 0.1.0 (not required in version 0.3.0). Nowadays, we see that this patch break scoped modules `like/this`, so this PR fixes it (basically, reverting the patch). **Test plan (required)** - [x] Try to link unscoped react-native package - [x] Try to link scoped react-native package **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests). Closes facebook#9118 Differential Revision: D3648488 fbshipit-source-id: 1891086ac79a89c888631592c966a8b33fd9c9fd
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: see facebook#8623 **Background:** Back in a days, one buggy patch sneaked into rnpm master. It was intended to fix `react-native-fbsdk` installation for version 0.1.0 (not required in version 0.3.0). Nowadays, we see that this patch break scoped modules `like/this`, so this PR fixes it (basically, reverting the patch). **Test plan (required)** - [x] Try to link unscoped react-native package - [x] Try to link scoped react-native package **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests). Closes facebook#9118 Differential Revision: D3648488 fbshipit-source-id: 1891086ac79a89c888631592c966a8b33fd9c9fd
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: see facebook/react-native#8623 **Background:** Back in a days, one buggy patch sneaked into rnpm master. It was intended to fix `react-native-fbsdk` installation for version 0.1.0 (not required in version 0.3.0). Nowadays, we see that this patch break scoped modules `like/this`, so this PR fixes it (basically, reverting the patch). **Test plan (required)** - [x] Try to link unscoped react-native package - [x] Try to link scoped react-native package **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests). Closes facebook/react-native#9118 Differential Revision: D3648488 fbshipit-source-id: 1891086ac79a89c888631592c966a8b33fd9c9fd
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #8623
Background:
Back in a days, one buggy patch sneaked into rnpm master. It was intended to fix
react-native-fbsdkinstallation for version 0.1.0 (not required in version 0.3.0). Nowadays, we see that this patch break scoped modules@like/this, so this PR fixes it (basically, reverting the patch).Test plan (required)
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.