-
Notifications
You must be signed in to change notification settings - Fork 25k
Added option to specify applicationId for Android builds #8867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
By analyzing the blame information on this pull request, we identified @burgalon and @jimthedev to be potential reviewers. |
|
cc @Kureev can we not detect it automatically? |
|
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @grabbou as a potential reviewer. Could you take a look please or cc someone with more context? |
|
Not that familiar with the subj. Is it something very common for every Android developer, @satya164? |
|
@Kureev For background, We currently support specifying build flavors for Android. They are just variants of the same app with some differences and a different application id. But What I'd prefer is to automatically detect the application id and launch it instead of having to specify the application id. It's pretty common to have build flavors for different environments on android. |
|
If there is a way to do it automatically, I'd like to kindly ask @enterline to change current implementation. |
|
Waiting for #8950 to update |
Allow optional
applicationIdbuild parameter. eg:It will then start the app with something like this:
Many times in Android, we have the need to set a different
applicationIdfor different build variants. eg:android { compileSdkVersion 23 buildToolsVersion "23.0.1" defaultConfig { applicationId "com.awesomeproject" minSdkVersion 16 targetSdkVersion 22 versionCode 1 versionName "1.0" ndk { abiFilters "armeabi-v7a", "x86" } } ... productFlavors { all { } ProdEnv { } DevEnv { applicationId "com.awesomeproject.devenv" } } ... }This should address issue #8308
Test plan (required)
We have been using this modified version of runAndroid for quite some time. I have tested with and without the parameter and builds that have different application ids and builds that do not.