Add .flowconfig to SampleApp so it will be included with react-native init #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Collaborator
Author
|
Oops just noticed #815 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 10, 2018
Summary: This consists of several fixes: - Some of the C++ functions called by the tests were missing `WIN_EXPORT` - It looks like Yoga was changed to round up after `TestMeasureFuncWithFloat` was written. Here's the function call that results in the rounding: https://github.com/facebook/yoga/blob/357ca78f9f7bd86298ef00a1426cac5ca2041d3b/yoga/Yoga.cpp#L4019-L4026 - The format of the result of the `Print` method was changed after `TestPrint` was written. Pull Request resolved: facebook/yoga#818 Differential Revision: D10282902 Pulled By: shergin fbshipit-source-id: a5fd732a7dbff1a704cbafbfc95ae3e0c0a0cdd8
t-nanava
referenced
this pull request
in microsoft/react-native-macos
Jun 17, 2019
Summary: This consists of several fixes: - Some of the C++ functions called by the tests were missing `WIN_EXPORT` - It looks like Yoga was changed to round up after `TestMeasureFuncWithFloat` was written. Here's the function call that results in the rounding: https://github.com/facebook/yoga/blob/357ca78f9f7bd86298ef00a1426cac5ca2041d3b/yoga/Yoga.cpp#L4019-L4026 - The format of the result of the `Print` method was changed after `TestPrint` was written. Pull Request resolved: facebook/yoga#818 Differential Revision: D10282902 Pulled By: shergin fbshipit-source-id: a5fd732a7dbff1a704cbafbfc95ae3e0c0a0cdd8
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
KusStar
pushed a commit
to KusStar/react-native
that referenced
this pull request
Oct 28, 2020
Summary: This consists of several fixes: - Some of the C++ functions called by the tests were missing `WIN_EXPORT` - It looks like Yoga was changed to round up after `TestMeasureFuncWithFloat` was written. Here's the function call that results in the rounding: https://github.com/facebook/yoga/blob/357ca78f9f7bd86298ef00a1426cac5ca2041d3b/yoga/Yoga.cpp#L4019-L4026 - The format of the result of the `Print` method was changed after `TestPrint` was written. Pull Request resolved: facebook/yoga#818 Differential Revision: D10282902 Pulled By: shergin fbshipit-source-id: a5fd732a7dbff1a704cbafbfc95ae3e0c0a0cdd8
acoates-ms
pushed a commit
to acoates-ms/react-native
that referenced
this pull request
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #784