Skip to content

Correct activity request code #7347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anshulagarwal06 wants to merge 2 commits into from
Closed

Correct activity request code #7347

anshulagarwal06 wants to merge 2 commits into from

Conversation

@anshulagarwal06
Copy link
Contributor

@anshulagarwal06 anshulagarwal06 commented May 3, 2016

Change activity request code to IMAGE_PICKER_REQUEST in currentActivity.startActivityForResult(chooserIntent, IMAGE_PICKER_REQUEST);

@anshulagarwal06
Correct activity request code
8826131 
Change activity request code to IMAGE_PICKER_REQUEST in currentActivity.startActivityForResult(chooserIntent, IMAGE_PICKER_REQUEST);
@ghost
Copy link

ghost commented May 3, 2016

By analyzing the blame information on this pull request, we identified @satya164 and @alvinthen to be potential reviewers.

@ghost
Copy link

ghost commented May 3, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@satya164
Copy link
Contributor

satya164 commented May 4, 2016

@anshulagarwal06 Can you please sign the CLA so that I can accept your PR?

@anshulagarwal06
Copy link
Contributor Author

anshulagarwal06 commented May 4, 2016

@satya164 : CLA Signed . you can accept PR

@ghost
Copy link

ghost commented May 4, 2016

@anshulagarwal06 updated the pull request.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 4, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2016
@satya164
Copy link
Contributor

satya164 commented May 4, 2016

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels May 4, 2016
@ghost
Copy link

ghost commented May 4, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in 60ee25c May 4, 2016
ptmt pushed a commit to ptmt/react-native that referenced this pull request May 9, 2016
@anshulagarwal06 @ptmt
Correct activity request code
f8172ae 
Summary:
Change activity request code to IMAGE_PICKER_REQUEST in currentActivity.startActivityForResult(chooserIntent, IMAGE_PICKER_REQUEST);
Closes facebook#7347

Differential Revision: D3257586

fb-gh-sync-id: fc92fb0bd3a66371fac22234b8a8b693a23fbf24
fbshipit-source-id: fc92fb0bd3a66371fac22234b8a8b693a23fbf24
zebulgar pushed a commit to nightingale/react-native that referenced this pull request Jun 18, 2016
@anshulagarwal06 @zebulgar
Correct activity request code
12f5cc4 
Summary:
Change activity request code to IMAGE_PICKER_REQUEST in currentActivity.startActivityForResult(chooserIntent, IMAGE_PICKER_REQUEST);
Closes facebook#7347

Differential Revision: D3257586

fb-gh-sync-id: fc92fb0bd3a66371fac22234b8a8b693a23fbf24
fbshipit-source-id: fc92fb0bd3a66371fac22234b8a8b693a23fbf24
bubblesunyum pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
@anshulagarwal06 @bubblesunyum
Correct activity request code
27ffdbe 
Summary:
Change activity request code to IMAGE_PICKER_REQUEST in currentActivity.startActivityForResult(chooserIntent, IMAGE_PICKER_REQUEST);
Closes facebook#7347

Differential Revision: D3257586

fb-gh-sync-id: fc92fb0bd3a66371fac22234b8a8b693a23fbf24
fbshipit-source-id: fc92fb0bd3a66371fac22234b8a8b693a23fbf24
@snyk-bot snyk-bot mentioned this pull request Nov 17, 2020
Open
@bumplzz69 bumplzz69 mentioned this pull request Nov 26, 2023
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anshulagarwal06 @satya164 @facebook-github-bot