fixed website deployment condition logic #7063
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
Website deployment worked but |
Contributor
Author
|
For got to push tags :) |
Contributor
Author
|
Passed now |
Contributor
Author
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
Contributor
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
grabbou
pushed a commit
that referenced
this pull request
May 4, 2016
Summary:Rookie mistake I made. **Test plan (required)** See that https://circleci.com/gh/facebook/react-native/5462 succeeds deploying the website correctly. Closes #7063 Differential Revision: D3196198 fb-gh-sync-id: 14fdc94fad0b1e5ff74cc90bb89d2bd1bf29bfa3 fbshipit-source-id: 14fdc94fad0b1e5ff74cc90bb89d2bd1bf29bfa3
ptmt
pushed a commit
to ptmt/react-native
that referenced
this pull request
May 9, 2016
Summary:Rookie mistake I made. **Test plan (required)** See that https://circleci.com/gh/facebook/react-native/5462 succeeds deploying the website correctly. Closes facebook#7063 Differential Revision: D3196198 fb-gh-sync-id: 14fdc94fad0b1e5ff74cc90bb89d2bd1bf29bfa3 fbshipit-source-id: 14fdc94fad0b1e5ff74cc90bb89d2bd1bf29bfa3
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:Rookie mistake I made. **Test plan (required)** See that https://circleci.com/gh/facebook/react-native/5462 succeeds deploying the website correctly. Closes facebook#7063 Differential Revision: D3196198 fb-gh-sync-id: 14fdc94fad0b1e5ff74cc90bb89d2bd1bf29bfa3 fbshipit-source-id: 14fdc94fad0b1e5ff74cc90bb89d2bd1bf29bfa3
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rookie mistake I made.
Test plan (required)
See that https://circleci.com/gh/facebook/react-native/5462 succeeds deploying the website correctly.