Skip to content

Whitelist the 'pdf' extension in the packager #7004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aprct wants to merge 8 commits into from
Closed

Whitelist the 'pdf' extension in the packager #7004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a6d9199
Whitelisted the 'pdf' extension in the packager according to @nickloc…
Apr 15, 2016
1b7e42f
Merge branch 'master' into packager-support-for-pdf-extension
aprct Apr 15, 2016
3fc0df3
Whitelisted the 'pdf' extension in the packager according to @nickloc…
Apr 15, 2016
92d6069
add missing RCTConvert import
majak Apr 15, 2016
00281f3
Update UIExplorer to Xcode_7.3
Apr 15, 2016
0498cc8
Round interpolation for RGB components
lelandrichardson Apr 15, 2016
6581fbf
Merge branch 'packager-support-for-pdf-extension' of https://github.c…
Apr 18, 2016
dd41a91
Merge branch 'master' into packager-support-for-pdf-extension
aprct Apr 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .flowconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ esproposal.class_instance_fields=enable
munge_underscores=true

module.name_mapper='^image![a-zA-Z0-9$_-]+$' -> 'GlobalImageStub'
module.name_mapper='^[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\)$' -> 'RelativeImageStub'
module.name_mapper='^[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\)$' -> 'RelativeImageStub'

suppress_type=$FlowIssue
suppress_type=$FlowFixMe
Expand Down
2 changes: 1 addition & 1 deletion local-cli/server/runServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function getPackagerServer(args, config) {
'bmp', 'gif', 'jpg', 'jpeg', 'png', 'psd', 'svg', 'webp', // Image formats
'm4v', 'mov', 'mp4', 'mpeg', 'mpg', 'webm', // Video formats
'aac', 'aiff', 'caf', 'm4a', 'mp3', 'wav', // Audio formats
'html', // Document formats
'html', 'pdf', // Document formats
Copy link
Contributor

@satya164 satya164 Apr 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad that we have the same list in 3 places.

Copy link
Contributor

@janicduplessis janicduplessis Apr 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move this config to https://github.com/facebook/react-native/blob/master/packager/rn-cli.config.js? It would allow everyone to add the extensions they need.

Copy link
Author

@aprct aprct Apr 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case would it have to be added to https://github.com/facebook/react-native/blob/master/packager/rn-cli.config.js as well? Still not exactly DRY if so.

Copy link
Contributor

@grabbou grabbou Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pdf is one of these things that should work as is in WebView (otherwise, except html I don't see any other use-case for it in React Native)

Copy link
Contributor

@satya164 satya164 Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should be in rn-cli.config. It's not a configuration option. It's just the list of what's supported by RN. If someone adds a random extension there it won't work, since the library doesn't support it.

],
resetCache: args.resetCache || args['reset-cache'],
verbose: args.verbose,
Expand Down
2 changes: 1 addition & 1 deletion packager/react-packager/src/Server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const validateOpts = declareOpts({
'bmp', 'gif', 'jpg', 'jpeg', 'png', 'psd', 'svg', 'webp', // Image formats
'm4v', 'mov', 'mp4', 'mpeg', 'mpg', 'webm', // Video formats
'aac', 'aiff', 'caf', 'm4a', 'mp3', 'wav', // Audio formats
'html', // Document formats
'html', 'pdf', // Document formats
],
},
transformTimeoutInterval: {
Expand Down