Support sending binary buffer over web socket in Android #6412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
By analyzing the blame information on this pull request, we identified @satya164, @aprock and @kevinstumpf to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
| } | ||
| try { | ||
| client.sendMessage( | ||
| WebSocket.PayloadType.BINARY, buffer); |
Contributor
There was a problem hiding this comment.
Can we get this on a single line?
|
Did you test this? Can you indicate how? |
Contributor
|
@sreesharp updated the pull request. |
Contributor
|
@sreesharp updated the pull request. |
1 similar comment
Contributor
|
@sreesharp updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support the binary buffer send in Websocket. Similar to the iOS support PR #6327