Skip to content

Conversation

@mkonicek
Copy link
Contributor

@mkonicek mkonicek commented Mar 7, 2016

This is an attempt to make #6039 work and see test results on Travis and CircleCI now both are green (tests fails on #6039):
https://travis-ci.org/facebook/react-native/builds
https://circleci.com/gh/facebook/react-native/tree/master

facebookarchive/node-haste#33 has been merged a 2.6.1 that contains it is in npm.

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @cpojer, @martinbigio and @spicyj to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 7, 2016
@mkonicek
Copy link
Contributor Author

mkonicek commented Mar 7, 2016

@skevy This is what I get when running npm test with npm 2:

$ npm test

[email protected] test /Users/mkonicek/code/react-native-mkonicek/react-native
NODE_ENV=test jest
Using Jest CLI v0.9.0-fb2, jasmine2
Error: Failed to build DependencyGraph: @providesModule naming collision:
Duplicate module name: update
Paths: /Users/mkonicek/code/react-native-mkonicek/react-native/node_modules/react/lib/update.js collides with /Users/mkonicek/code/react-native-mkonicek/react-native/website/node_modules/react/lib/update.js
This error is caused by a @providesModule declaration with the same name accross two different files.
This is most likely a setup or configuration issue. To resolve a module name collision, change or blacklist one of the offending modules. See http://facebook.github.io/jest/docs/api.html#config-modulepathignorepatterns-array-string
npm ERR! Test failed. See above for more details.

// should work after this release and we can
// remove it from here.
'parse',
{ name: 'parse', parent: null },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6039 also contained fbjs here but it's gone on master.

@mkonicek
Copy link
Contributor Author

mkonicek commented Mar 7, 2016

@skevy Since this updates package.json I tried running npm install and then npm shrinkwrap --dev. Looks like an issue specific to my machine. Before and after this is what shrinkwrap contains (note the wrong version and localhost:4873 - this is Sinopia's port): http://pastebin.com/Ch7HYN8R

However:

$ npm config list
registry = "https://registry.npmjs.org/"

I tried rm -rf node_modules and npm install from scratch, the shrinkwrap file still

But even then, the version in master should be 2.4.0 but it is 2.2.0 in the shrinkwrap file? Is the file on GitHub correct? https://github.com/facebook/react-native/blob/master/npm-shrinkwrap.json

When running an e2e test locally (publish into sinopia, react-native init - same what we do on Travis), I get: http://pastebin.com/DB0aHzhS

I'm using npm 2:

$ npm -v
2.7.1

@skevy skevy mentioned this pull request Mar 7, 2016
@skevy
Copy link
Contributor

skevy commented Mar 7, 2016

Closing in favor of #6346.

@skevy skevy closed this Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants