explicitly track lifetime of NativeAnimatedNodesManager #54477
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## Changelog: [General] [Fixed] - explicitly track lifetime of NativeAnimatedNodesManager mark the instance as destroyed with an atomic bool, and avoid passing down `onRender` to platform via `startOnRenderCallback` if instance is being destroyed An alternative to this is referencing NativeAnimatedNodesManager instance with shared_from_this() instead of `this`, but that will increase binary size Differential Revision: D86672542
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General] [Fixed] - explicitly track lifetime of NativeAnimatedNodesManager
mark the instance as destroyed with an atomic bool, and avoid passing down
onRenderto platform viastartOnRenderCallbackif instance is being destroyedAn alternative to this is referencing NativeAnimatedNodesManager instance with shared_from_this() instead of
this, but that will increase binary sizeDifferential Revision: D86672542