Properly setup headers for FBReactNativeSpec in prebuilds #52783
+24
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78803425 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 23, 2025
…2783) Summary: This change reverts D78158734 which was a patch to make the dynamic frameworks work properly because we were not exporting the FBReactNativeSpec headers in prebuilds correctly. This change fixes this, by exposritng those headers correctly. ## Changelog: [Internal] - Differential Revision: D78803425
cipolleschi
force-pushed
the
export-D78803425
branch
from
6c0e12b to
f4cb129
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78803425 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 23, 2025
…2783) Summary: Pull Request resolved: facebook#52783 This change reverts D78158734 which was a patch to make the dynamic frameworks work properly because we were not exporting the FBReactNativeSpec headers in prebuilds correctly. This change fixes this, by exposritng those headers correctly. ## Changelog: [Internal] - Differential Revision: D78803425
cipolleschi
force-pushed
the
export-D78803425
branch
2 times, most recently
from
9cb8def to
a435b6c
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 23, 2025
…2783) Summary: This change reverts D78158734 which was a patch to make the dynamic frameworks work properly because we were not exporting the FBReactNativeSpec headers in prebuilds correctly. This change fixes this, by exposritng those headers correctly. ## Changelog: [Internal] - Differential Revision: D78803425
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78803425 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 23, 2025
…2783) Summary: This change reverts D78158734 which was a patch to make the dynamic frameworks work properly because we were not exporting the FBReactNativeSpec headers in prebuilds correctly. This change fixes this, by exposritng those headers correctly. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D78803425
cipolleschi
force-pushed
the
export-D78803425
branch
from
a435b6c to
85bd27e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78803425 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 23, 2025
…2783) Summary: This change reverts D78158734 which was a patch to make the dynamic frameworks work properly because we were not exporting the FBReactNativeSpec headers in prebuilds correctly. This change fixes this, by exposritng those headers correctly. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D78803425
cipolleschi
force-pushed
the
export-D78803425
branch
2 times, most recently
from
5a80b60 to
d2ced78
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 23, 2025
…2783) Summary: This change reverts D78158734 which was a patch to make the dynamic frameworks work properly because we were not exporting the FBReactNativeSpec headers in prebuilds correctly. This change fixes this, by exposritng those headers correctly. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D78803425
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78803425 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78803425 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 23, 2025
…2783) Summary: Pull Request resolved: facebook#52783 This change reverts D78158734 which was a patch to make the dynamic frameworks work properly because we were not exporting the FBReactNativeSpec headers in prebuilds correctly. This change fixes this, by exposritng those headers correctly. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D78803425
cipolleschi
force-pushed
the
export-D78803425
branch
from
d2ced78 to
a8ed74f
Compare
…2783) Summary: This change reverts D78158734 which was a patch to make the dynamic frameworks work properly because we were not exporting the FBReactNativeSpec headers in prebuilds correctly. This change fixes this, by exposritng those headers correctly. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D78803425
cipolleschi
force-pushed
the
export-D78803425
branch
from
a8ed74f to
e0ccb58
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78803425 |
Contributor
|
This pull request has been merged in c71c681. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in c71c681 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
added a commit
that referenced
this pull request
Jul 29, 2025
Summary: bypass-github-export-checks Pull Request resolved: #52783 This change reverts D78158734 which was a patch to make the dynamic frameworks work properly because we were not exporting the FBReactNativeSpec headers in prebuilds correctly. This change fixes this, by exposritng those headers correctly. [Internal] - bypass-github-export-checks Reviewed By: cortinico Differential Revision: D78803425 fbshipit-source-id: 5613ed0c790455ea86668eeb436f7b78a0c80918
Collaborator
|
This pull request was successfully merged by @cipolleschi in b00a918 When will my fix make it into a release? | How to file a pick request? |
motiz88
pushed a commit
that referenced
this pull request
Jul 29, 2025
…52897) Summary: bypass-github-export-checks Pull Request resolved: #52783 This change reverts D78158734 which was a patch to make the dynamic frameworks work properly because we were not exporting the FBReactNativeSpec headers in prebuilds correctly. This change fixes this, by exposritng those headers correctly. [Internal] - bypass-github-export-checks Reviewed By: cortinico Differential Revision: D78803425 fbshipit-source-id: 5613ed0c790455ea86668eeb436f7b78a0c80918
Collaborator
|
This pull request was successfully merged by @cipolleschi in 5976618 When will my fix make it into a release? | How to file a pick request? |
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
…2783) Summary: bypass-github-export-checks Pull Request resolved: facebook#52783 This change reverts D78158734 which was a patch to make the dynamic frameworks work properly because we were not exporting the FBReactNativeSpec headers in prebuilds correctly. This change fixes this, by exposritng those headers correctly. ## Changelog: [Internal] - bypass-github-export-checks Reviewed By: cortinico Differential Revision: D78803425 fbshipit-source-id: 5613ed0c790455ea86668eeb436f7b78a0c80918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change reverts D78158734 which was a patch to make the dynamic frameworks work properly because we were not exporting the FBReactNativeSpec headers in prebuilds correctly.
This change fixes this, by exposritng those headers correctly.
Changelog:
[Internal] -
Differential Revision: D78803425