ReactInstanceManager: Move clearReactRoot call to ensure proper cleanup

[maugou]

Summary:

Trying to add a root view with an explicit id (11) already set. React Native uses the id field to track react tags and will overwrite this field. If that is fine, explicitly overwrite the id field to View.NO_ID before calling addRootView.

This issue affects Android only and is triggered by another library that calls recreateReactContextInBackground.
In my case, it occurred when performing an immediate reload under the old architecture using react-native-code-push.

The issue can be fixed by simply moving the clearReactRoot call inside detachRootViewFromInstance so that it also runs in the old-architecture code path.

Changelog:

[ANDROID] [FIXED] - Ensure clearReactRoot runs for the old architecture as well, preventing leaked views and crashes when recreateReactContextInBackground() is called.

Test Plan:

Please refer to #50274.

[facebook-github-bot]

Hi @maugou!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[javache]

This issues applies to the old architecture only, which we've now frozen per reactwg/react-native-new-architecture#290