-
Notifications
You must be signed in to change notification settings - Fork 25k
fixes #40314 - index.flow.js #51886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #40314 - index.flow.js #51886
Conversation
fixes facebook#40314 - index.flow.js - Added Index.flow.js for MacOS Systems
|
Hi @aswinandro! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@aswinandro Hey! Happy to accept this. But what I would say too is we haven't been considering our open source support for React Native + Flow as supported for a couple of years 😅
See also #51556 recently. |
|
@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
huntie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, we cannot accept any of the file changes to index.js.flow itself — please update to include only the package.json change.
Preserved Original index.flow.js
|
Replaced by #51908. |
fixes #40314 - index.flow.js - Added Index.flow.js for MacOS Systems
Summary:
Changelog:
Add index.js.flow to npm package files for Flow support
Currently, the distributed npm package for react-native does not include the index.js.flow file, which causes all exports to be typed as any when using Flow. This commit adds index.js.flow to the "files" array in package.json, ensuring Flow users receive proper type definitions out of the box. This addresses issues where type checking with Flow fails in React Native projects.
FIXED - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
Test Plan: