[iOS] RNTester: Fixes turbo module examples error in bridgeless mode #48362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
@RSNara has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
RSNara
reviewed
Jan 2, 2025
packages/rn-tester/js/examples/TurboModule/NativeCxxModuleExampleExample.js
Outdated
Show resolved
Hide resolved
Collaborator
|
Btw, I just spotted this in Android and the TurboModule examples are broken there as well (not limited to iOS only). I tested these changes and works good for both now with it 🎉
|
Contributor
Author
@mateoguzmana Amazing! Thank you for the test. 🤗 @RSNara help to review it? |
Contributor
Author
|
@christophpurrer @cortinico Seems #49028 try to fix turbo example in bridgeless mode. But it should throw the error in paper mode. Could you please review this PR? |
Collaborator
|
This pull request was successfully merged by @zhongwuzw in 62831e7 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
@cortinico merged this pull request in 62831e7. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
…#49329) Summary: Reland #48362. ## Changelog: [IOS] [FIXED] - RNTester: Fixes turbo module examples error in bridgeless mode Pull Request resolved: #49329 Test Plan: RNTester turbomodule examples in bridgeless can work as expected. Reviewed By: christophpurrer Differential Revision: D69463612 Pulled By: cortinico fbshipit-source-id: 8613b001ebbe64ce0d505f5515bb7a4b6a64dbe7
6 tasks
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
…ook#48362) Summary: In facebook#47598 , we removed `__turboModuleProxy ` in bridgeless mode, it would produce error in rntester turbomodule examples, fix it by change `__turboModuleProxy` to `nativeModuleProxy`. RSNara can you please help to review? :) before:  After:  ## Changelog: [IOS] [FIXED] - RNTester: Fixes turbo module examples error in bridgeless mode Pull Request resolved: facebook#48362 Test Plan: RNTester turbomodule examples in bridgeless can work as expected. Reviewed By: shwanton Differential Revision: D67603884 Pulled By: cortinico fbshipit-source-id: d905fa0535da5fde5e7ebff1d453ea761be9f42f
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
…facebook#49329) Summary: Reland facebook#48362. ## Changelog: [IOS] [FIXED] - RNTester: Fixes turbo module examples error in bridgeless mode Pull Request resolved: facebook#49329 Test Plan: RNTester turbomodule examples in bridgeless can work as expected. Reviewed By: christophpurrer Differential Revision: D69463612 Pulled By: cortinico fbshipit-source-id: 8613b001ebbe64ce0d505f5515bb7a4b6a64dbe7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In #47598 , we removed
__turboModuleProxyin bridgeless mode, it would produce error in rntester turbomodule examples, fix it by change__turboModuleProxytonativeModuleProxy. @RSNara can you please help to review? :)before:
After:
Changelog:
[IOS] [FIXED] - RNTester: Fixes turbo module examples error in bridgeless mode
Test Plan:
RNTester turbomodule examples in bridgeless can work as expected.