Move BridgelessDevSupportManager inside .devsupport #46914
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64105790 |
Contributor
Author
|
cc @alanjhughes |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 9, 2024
…ook#46914) Summary: This is a WIP Changelog: [Android] [Changed] - Allow customization of BridgelessDevSupportManager for Expo Go Reviewed By: rshest Differential Revision: D64105790
cortinico
force-pushed
the
export-D64105790
branch
from
6d83959 to
f236a98
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64105790 |
cortinico
force-pushed
the
export-D64105790
branch
from
f236a98 to
e543237
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 10, 2024
…ook#46914) Summary: This is a WIP Changelog: [Android] [Changed] - Allow customization of BridgelessDevSupportManager for Expo Go Reviewed By: rshest Differential Revision: D64105790
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64105790 |
cortinico
changed the title
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64105790 |
cortinico
force-pushed
the
export-D64105790
branch
from
e543237 to
cdb61bb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64105790 |
cortinico
force-pushed
the
export-D64105790
branch
from
cdb61bb to
61ed65a
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 16, 2024
Summary: Pull Request resolved: facebook#46914 The `BridgelessDevSupportManager` should have lived inside the `.devsupport` package alongside all the other devsupport related tooling. It was instead created inside `.runtime` causing a tight coupling with `ReactHostImpl`. This made it impossible for Frameworks to customize it (i.e. in Expo GO) also because there was a circular dependency between ReactHostImpl and BridgelessDevSupportManager In this diff I'm: 1. Breaking the circular dependency by using `ReactHostDevHelper` 2. Updating all the parameters to reference `ReactHost` rather than `ReactHostImpl` 3. Moving BridgelessDevSupportManager to the `.devsupport` package. This is breaking for users that are manually composing a `BridgelessDevSupportManager` or that are extending the `ReactInstanceDevHelper`. - `ReactInstanceDevHelper` has 3 new method which will have to be implemented. - `BridgelessDevSupportManager` is now living in a different package. Changelog: [Android] [Breaking] - Add 3 methods to ReactInstanceDevHelper Reviewed By: rshest Differential Revision: D64105790
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 16, 2024
Summary: Pull Request resolved: facebook#46914 The `BridgelessDevSupportManager` should have lived inside the `.devsupport` package alongside all the other devsupport related tooling. It was instead created inside `.runtime` causing a tight coupling with `ReactHostImpl`. This made it impossible for Frameworks to customize it (i.e. in Expo GO) also because there was a circular dependency between ReactHostImpl and BridgelessDevSupportManager In this diff I'm: 1. Breaking the circular dependency by using `ReactHostDevHelper` 2. Updating all the parameters to reference `ReactHost` rather than `ReactHostImpl` 3. Moving BridgelessDevSupportManager to the `.devsupport` package. This is breaking for users that are manually composing a `BridgelessDevSupportManager` or that are extending the `ReactInstanceDevHelper`. - `ReactInstanceDevHelper` has 3 new method which will have to be implemented. - `BridgelessDevSupportManager` is now living in a different package. Changelog: [Android] [Breaking] - Add 3 methods to ReactInstanceDevHelper Reviewed By: rshest Differential Revision: D64105790
cortinico
force-pushed
the
export-D64105790
branch
from
61ed65a to
7a18e05
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64105790 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64105790 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 16, 2024
Summary: Pull Request resolved: facebook#46914 The `BridgelessDevSupportManager` should have lived inside the `.devsupport` package alongside all the other devsupport related tooling. It was instead created inside `.runtime` causing a tight coupling with `ReactHostImpl`. This made it impossible for Frameworks to customize it (i.e. in Expo GO) also because there was a circular dependency between ReactHostImpl and BridgelessDevSupportManager In this diff I'm: 1. Breaking the circular dependency by using `ReactHostDevHelper` 2. Updating all the parameters to reference `ReactHost` rather than `ReactHostImpl` 3. Moving BridgelessDevSupportManager to the `.devsupport` package. This is breaking for users that are manually composing a `BridgelessDevSupportManager` or that are extending the `ReactInstanceDevHelper`. - `ReactInstanceDevHelper` has 3 new method which will have to be implemented. - `BridgelessDevSupportManager` is now living in a different package. Changelog: [Android] [Breaking] - Add 3 methods to ReactInstanceDevHelper Reviewed By: rshest Differential Revision: D64105790
cortinico
force-pushed
the
export-D64105790
branch
from
7a18e05 to
fca38a4
Compare
Summary: Pull Request resolved: facebook#46914 The `BridgelessDevSupportManager` should have lived inside the `.devsupport` package alongside all the other devsupport related tooling. It was instead created inside `.runtime` causing a tight coupling with `ReactHostImpl`. This made it impossible for Frameworks to customize it (i.e. in Expo GO) also because there was a circular dependency between ReactHostImpl and BridgelessDevSupportManager In this diff I'm: 1. Breaking the circular dependency by using `ReactHostDevHelper` 2. Updating all the parameters to reference `ReactHost` rather than `ReactHostImpl` 3. Moving BridgelessDevSupportManager to the `.devsupport` package. This is breaking for users that are manually composing a `BridgelessDevSupportManager` or that are extending the `ReactInstanceDevHelper`. - `ReactInstanceDevHelper` has 3 new method which will have to be implemented. - `BridgelessDevSupportManager` is now living in a different package. Changelog: [Android] [Breaking] - Add 3 methods to ReactInstanceDevHelper Reviewed By: rshest Differential Revision: D64105790
cortinico
force-pushed
the
export-D64105790
branch
from
fca38a4 to
71b07df
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64105790 |
Contributor
|
This pull request has been merged in c867aba. |
Collaborator
|
This pull request was successfully merged by @cortinico in c867aba When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BridgelessDevSupportManagershould have lived inside the.devsupportpackage alongside all the otherdevsupport related tooling.
It was instead created inside
.runtimecausing a tight coupling withReactHostImpl.This made it impossible for Frameworks to customize it (i.e. in Expo GO) also because there was a circular
dependency between ReactHostImpl and BridgelessDevSupportManager
In this diff I'm:
ReactHostDevHelperReactHostrather thanReactHostImpl.devsupportpackage.This is breaking for users that are manually composing a
BridgelessDevSupportManagerorthat are extending the
ReactInstanceDevHelper.ReactInstanceDevHelperhas 3 new method which will have to be implemented.BridgelessDevSupportManageris now living in a different package.Changelog:
[Android] [Breaking] - Add 3 methods to ReactInstanceDevHelper
Reviewed By: rshest
Differential Revision: D64105790