feat: deprecate passing separate new arch flags to RCTRootViewFactory

[okwasniewski]

Summary:

This PR follows up with the deprecation introduced here: #46228

The idea is to have new architecture depend on one flag, namely newArchEnabled. It exposes additional initializers for RCTRootViewFactory.

Changelog:

[IOS] [CHANGED] - Use newArchEnabled flag in RCTAppDelegate and RCTRootViewFactory

Test Plan:

CI Green

[cipolleschi]

Sadly, we can't merge this. If we do this, people will not be able to turn off selectively parts of the New Architecture, and we are not ready to remove this possibility just yet.

[okwasniewski]

@cipolleschi Yeah, I was afraid its too early 😅 Do you think we can deprecate RCTRootViewFactory initializers?

[cipolleschi]

Do you think we can deprecate RCTRootViewFactory initializers?

What do you mean? Do you want to move away from some initializers?

[okwasniewski]

Do you think we can deprecate RCTRootViewFactory initializers?

What do you mean? Do you want to move away from some initializers?

@cipolleschi Yeah, I want to deprecate initializers that accept multiple flags

Deprecate this:

- (instancetype)initWithBundleURL:(NSURL *)bundleURL
                   newArchEnabled:(BOOL)newArchEnabled
               turboModuleEnabled:(BOOL)turboModuleEnabled
                bridgelessEnabled:(BOOL)bridgelessEnabled

And make this preferred:

- (instancetype)initWithBundleURL:(NSURL *)bundleURL
                   newArchEnabled:(BOOL)newArchEnabled

So users that rely on setting different flags can still use it but for new (brownfield) integrations they can use newArchEnabled parameter.

[cipolleschi]

Yeah, that seems reasonable to me.

[okwasniewski]

@cipolleschi I've deprecated the initializers

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi merged this pull request in 7e1674f.

[react-native-bot]

This pull request was successfully merged by @okwasniewski in 7e1674f

^{When will my fix make it into a release? | How to file a pick request?}