Basic <Video> tag implementation #466
Conversation
Libraries/Video/VideoContentModes.m
Outdated
There was a problem hiding this comment.
No need for this extra module, you can move it into RCTVideoManager.m
|
Really like the look of this 👍 |
|
Hey, this looks great but in the past I've noticed a few issues with Internally, we have a wrapper around |
|
@grp - that would be great! Looking forward to seeing it |
|
Actually, I think this would be better for you to create a separate github repo for this specific component, iterate on it and when it reaches maturity we can see about including it in the main repo. Otherwise we're going to slow you down as we're not going to include something half baked as part of the core build. |
|
@vjeux - that makes total sense, agreed |
|
@vjeux - repo is here: https://github.com/brentvatne/react-native-video /cc @grp @tadeuzagallo |
Summary: We need to take the margin into account if we clip on max dimension. Fixes #466. Closes facebook/yoga#467 Differential Revision: D4681342 Pulled By: emilsjolander fbshipit-source-id: 56311df9864a284d553c31f1c6db382f337f1fad
… for each version of React Native. As a result, people can go back and see what a View component looked like in any past React Native release. (#466) This is less relevant for "evergreen" content such as the Getting Started guide, the Tutorial, and basically the rest of the Guides. These docs should be getting updated across all versions at the same time. This script makes sure we are not tracking separate versions of a unversioned doc. We achieve this by ensuring any changes made to these files in `docs/` are then persisted to the `versioned_docs/version-0.5` folder, as Version 0.5 is the oldest document version. This makes it so that the same text is displayed to the reader, regardless of what version they are looking at. This script is not yet invoked in CI or as a pre-commit hook, but the plan is to enable it soon.
5 participants
Put this together together today with the help of @tadeuzagallo, far from complete but you can see it in action in my react-native-login repo.
Special props beyond the standard
RCTView:resizeModewith the same options asImagesourcewhich just accepts a string currently, which is then used to locate the resource locally.Some remaining tasks:
require('video!...')