Hotfix privacy manifest aggregation script

[aleqsio]

Summary:

As pointed out by @liamjones here:
#44214 (comment)

The original PR did introduce a bug in the find/first check, but in my testing, we do need to look at group.name, so let's make sure we check both.

This also makes it play nice with an existing file even if it is added to a different directory, by appending to it instead of forcing it to exist in the main group.

Changelog:

[IOS] [FIXED] - Fix privacy aggregation

Test Plan:

Tested on rn-tester

[facebook-github-bot]

@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

I picked the changes manually in 0.74.1, no need for a pick request there.

We will need the pick request for 71 and 72, though.

[facebook-github-bot]

@philIip merged this pull request in 00b3661.

[github-actions]

This pull request was successfully merged by @aleqsio in 00b3661.

^{When will my fix make it into a release? | How to file a pick request?}

[liamjones]

Thanks for the patch @aleqsio!

but in my testing, we do need to look at group.name, so let's make sure we check both

I realised why we were getting different behaviour here. There are two types of groups in Xcode; those with folders on the f/s and those without them. Groups with folders have a path, and groups without folders have a name:

[aleqsio]

Thanks for the patch @aleqsio!

but in my testing, we do need to look at group.name, so let's make sure we check both

I realised why we were getting different behaviour here. There are two types of groups in Xcode; those with folders on the f/s and those without them. Groups with folders have a path, and groups without folders have a name:

That makes sense - now we're checking for both so it should be fine, with a fallback to save to root if we find none.

Thank you for reporting this so early 💛